From: Florian Müllner <fmuellner@gnome.org>
Date: Wed, 11 Mar 2015 16:25:25 +0000 (+0100)
Subject: messageTray: Always destroy banners when done displaying
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~1454
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=2d4ba30ba25c064f44fd4a0a76559baa089b3691;p=gnome-shell.git

messageTray: Always destroy banners when done displaying

Special-casing banners of resident notifications was really a
thinly veiled special case for chat notifications, as those were
still using the old notification actor which coupled the life-time
of the notification to its actor. This is no longer the case, so
we can do the sane thing and destroy banners once they are no
longer needed.

https://bugzilla.gnome.org/show_bug.cgi?id=746343
---

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 4d7d93518..b69492b05 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -2091,10 +2091,7 @@ const MessageTray = new Lang.Class({
         this._pointerInNotification = false;
         this._notificationRemoved = false;
 
-        if (notification.resident)
-            this._bannerBin.remove_actor(this._banner.actor);
-        else
-            this._banner.actor.destroy();
+        this._banner.actor.destroy();
         this._banner = null;
         this.actor.hide();
     },